search

techgaun / ad-bs-converter

A javascript implementation to convert bikram samvat to anno domini and vice-versa
29 stars 18 forks source link

Add total number of days in nepali month #3

Closed subashadhi closed 6 years ago

subashadhi commented 6 years ago

Great job man on creating the package. 👍

Can you add totaldays: calendar_data[bs_date.year][bs_date.month-1] to the dateObj in offsetBSDays function so that we can also find the total number of days in the month? This in my view will be useful in a number of different scenarios.

techgaun commented 6 years ago

@subash95 how does above pull request look like?

subashadhi commented 6 years ago

@techgaun perfect! Has this also been synced with the npm package?

techgaun commented 6 years ago

@subash95 I've not. Was waiting to see what you think of it. Am gonna publish it now

techgaun commented 6 years ago

@subash95 published

subashadhi commented 6 years ago

Thanks.