techgaun / zxcvbn-elixir

Elixir implementation of zxcvbn by dropbox
Apache License 2.0
55 stars 7 forks source link

Extract helper functions for most_guessable_match_sequence #15

Closed axelson closed 5 years ago

axelson commented 5 years ago

Had to introduce a couple additional parameters that previously were being captured by the closure. Also re-ordered the parameters to be a little more consistent (always put password first). Hopefully the order I choose makes sense!

most_guessable_match_sequence/3 is probably large enough that it could be extracted to it's own module.

Partially addresses #12