search

techie66 / EngineDataLogger

Data logger and master controller for Raspberry Pi based ECU that communicates with various external MCUs
GNU General Public License v3.0
5 stars 0 forks source link

Regression: Lambda value calculated incorrectly #31

Closed techie66 closed 1 year ago

techie66 commented 1 year ago

https://github.com/techie66/EngineDataLogger/blob/9d348beb740caed83c5e7f0b3920feb37c9e88e4/src/main.cpp#L857

techie66 commented 1 year ago

https://github.com/techie66/EngineDataLogger/blob/9d348beb740caed83c5e7f0b3920feb37c9e88e4/src/definitions.h#L151

techie66 commented 1 year ago

Should be 1000 not 100. Need test for this. Make the fix in current and backport to stable for point release.

techie66 commented 1 year ago

that was done on purpose. oops :-( https://github.com/techie66/EngineDataLogger/blob/9d348beb740caed83c5e7f0b3920feb37c9e88e4/src/can.cpp#L77

26 was fixed incorrectly

2673fbf adds tests, reverts the changes from 1d1ae4e , and correctly fixes in can.cpp