search

techiediaries / ngx-qrcode

An Angular 9/10 Component Library for Generating QR (Quick Response) Codes
https://techiediaries.com/ngx-qrcode/
MIT License
192 stars 62 forks source link

Warning alert when upgrading to angular 10 #60

Open Slash7GNR opened 4 years ago

Slash7GNR commented 4 years ago

Hi, When running ng build / serve, I'm receiving the following warning:

WARNING in /Users/inno/Desktop/Kobura/kob-ui/node_modules/@techiediaries/ngx-qrcode/__ivy_ngcc__/fesm2015/ngx-qrcode2.js depends on 'qrcode'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

There is a way to suppress the error by adding 'qrcode' to 'allowedCommonJsDependencies' in the angular.json file. Is there any way you can solve this warning without suppressing it ?

Best regards, Nadav

rafa-suagu commented 4 years ago

Thanks for your comments @Slash7GNR .

We will work to make this library fully compatible with Angular 10 the next weeks. Stay tuned.

beeing commented 4 years ago

Hi, any updates on this?

Is this a simple fix or need some kind of restructuring?

Maik-Robin commented 3 years ago

Hi, @rafa-as this WARNING Message is still apperaing. We'd like to use your component, but we do have some concerns regarding this Message. Can you provide some more information and has Angular 10 full supported yet?

pauloneill commented 3 years ago

This is still happening for me in Angular 10 - any update please?

morgan-wild commented 3 years ago

Up! Same issue here :)

beeing commented 3 years ago

This is also based on https://github.com/soldair/node-qrcode/pull/241 which is not merged.

Also looks like the repo is not really maintained. Perhaps can create fork to test this out.

mw108 commented 1 year ago

2023 and the warning still appears.