search

techiew / DirectXHook

DirectX 11/12 hook including a simple overlay framework.
181 stars 23 forks source link

Exception can't printdebugmsg Original bytes ... #1

Closed ShhShadShh closed 3 years ago

ShhShadShh commented 3 years ago

so do i need the original dxgi.dll together with the one i build in the same game folder or only the compiled one ? im also getting this exception do you know what this can be ? IMAGE(right click>open image in new tab to fullscreen it ) : https://imgur.com/a/EvGkC8f

ShhShadShh commented 3 years ago

i swapped hook( present ) with hook ( resize buffer) and Present went through but resize buffer still fails: https://imgur.com/a/1UuSGMT

any idea what can be wrong with Hook(targetResizeBuffersFunction, &ResizeBuffers ????????

ShhShadShh commented 3 years ago

so i commented out the Hook(targetResizeBuffersFunction, &ResizeBuffers, function and now it works somewhat : https://imgur.com/a/rGMCXie still no idea whats wrong with Resizebuffer hook

geometry88 commented 3 years ago

The problem was solved by adding an input argument IDXGISwapChain* pThis to the function ResizeBuffers and OnResizeBuffers

ShhShadShh commented 3 years ago

The problem was solved by adding an input argument IDXGISwapChain* pThis to the function ResizeBuffers and OnResizeBuffers

idk still doesn't work what am i doing wrong ? IMGUR > imgur

geometry88 commented 3 years ago

here too, and yes, I noticed that on different operating systems dxgi offsets are different ... maybe this is the problem Screenshot_20201127-210836

ShhShadShh commented 3 years ago

here too, and yes, I noticed that on different operating systems dxgi offsets are different ... maybe this is the problem

must be different dxgi offsets yeah...

techiew commented 3 years ago

Oh hey guys, I haven't received any email notification about this issue whatsoever, I just randomly stumbled on it right now. I remember @ShhShadShh from my Youtube comments tho.

It seems my signature scanning approach for finding the function addresses in dxgi is very unstable, the culprit is likely to be different versions of dxgi.dll, I've experienced firsthand that the function addresses can move around a bit after a Windows update. As for @geometry88's extra input argument for ResizeBuffers, I'll have to check in the documentation if they added a new argument or something. Thank you guys for your interest in my project.

I want to continue working on this project, it's not high priority right now, but I definitely want to look into it.

techiew commented 3 years ago

I did a massive rewrite and the hook now uses virtual method table hooking, so wrong offsets and stuff should no longer be an issue across different computers. If anyone still has problems then please post them in another issue.

cb20bb2ad5418cb1a17d8c3ce2f724b495e79642