search

techiferous / tabulous

Easy tabbed navigation for Rails
Other
322 stars 35 forks source link

support namespaced controllers, e.g. /my/orders #18

Closed vitaly closed 11 years ago

vitaly commented 11 years ago

use controller_path instead of controller_name. so that we get :"my/orders" instead of just :orders for My::OrdersController

techiferous commented 11 years ago

@vitaly Thanks so much for this fix. Unfortunately, although your fix is correct, it would break backwards-compatibility.

I made the unfortunate design choice to simply ignore namespaces, so currently tabulous can work with namespaced controllers as long as the controllers have different names (the namespace is not the only thing disambiguating them). I consider this a design error in tabulous.

If I do a major upgrade of tabulous in the future, I'll roll this namespace consideration in.

I'm going to leave this issue open to remind me to roll this in when I'm ready to release a backwards-compatibility-breaking version of tabulous.

techiferous commented 11 years ago

Namespaced controllers are now fully supported in tabulous version 2. Thank you for bringing this issue to my attention!