search

techiferous / tabulous

Easy tabbed navigation for Rails
Other
322 stars 35 forks source link

Support for HTTP methods #23

Closed GreySyntax closed 11 years ago

GreySyntax commented 11 years ago

Example usage:


      [ :signup_tab, 'Sign Out', destroy_user_session_path, user_signed_in?, true, :delete ],
GreySyntax commented 11 years ago

The method argument is optional and not required, this will work for rails 3 and up.

samzhao commented 11 years ago

AWESOME!

GreySyntax commented 11 years ago

@techiferous Any idea if this will be merged at some point?

techiferous commented 11 years ago

No, this will never be merged. After some thought I've decided that I don't want to support non-GET actions for tabs. I take the position that tabs are navigation elements for switching between pages, and therefore should always be GETs. Actions like signing out should not be tabs, but links or buttons.

GreySyntax commented 11 years ago

Fair enough guess this can be closed.

techiferous commented 10 years ago

@GreySyntax It's taken me 9 months, but I've changed my mind and added support for HTTP verbs.

Sorry for the lateness. It's probably a moot point for you now, but I thought I'd let you know that the functionality made it in!

GreySyntax commented 10 years ago

Thats great news thanks for the update!