search

techiferous / tabulous

Easy tabbed navigation for Rails
Other
322 stars 35 forks source link

CSS scaffolding lacks float clearing for subtabs #34

Closed tovodeverett closed 10 years ago

tovodeverett commented 11 years ago

While using the generated CSS scaffolding as a start for working on my own CSS, I noticed the float clearing section for .tabs ul. That also explained why I had to clear the floats manually when using subtabs. Modifying that section to also clear .subtabs ul seemed to help.

.tabs ul, .subtabs ul {
  /* float clearing */
  overflow: hidden;
  display: inline-block; /* Necessary to trigger "hasLayout" in IE */
  display: block; /* Sets element back to block */
}

P.S. Thanks for Tabulous!

techiferous commented 11 years ago

Great, thank you! I'll leave this issue open so that the next time I'm hacking on tabulous I'll remember to make this improvement.

techiferous commented 10 years ago

This is now fixed in tabulous 2.1.0. Thank you.