search

techiferous / tabulous

Easy tabbed navigation for Rails
Other
322 stars 35 forks source link

links inside are disabled #36

Closed yehudaTiram closed 11 years ago

yehudaTiram commented 11 years ago

Hello, This is a good plugin. Thank you for your good work. I have 2 comments though:

  1. I see that actually you cannot use anchors inside since there is a "e.preventDefault();" code on any click. I guess it is meant for the tabs links, but what if you wnat a link inside the tab? Did I miss something here?
  2. I use an imageCaption plugin (https://github.com/ibuypink/jQuery.imageCaption) That adds divs around images in order to set the alt tag as the image caption. I tried to implement it on some images inside the tabs, but all the layout inside the tab gets messed up. It seems that the var alldivs in your code is a bit too sweeping and does not let adding other divs inside. Just a thought.

Thanks, Yehuda

techiferous commented 11 years ago

Hi! You're actually at the wrong source code repository. This tabulous is about Ruby on Rails. You're looking for tabulous.js. https://github.com/aarondo/tabulous.js

Happy tabbing!