search

techiferous / tabulous

Easy tabbed navigation for Rails
Other
322 stars 35 forks source link

Allow <ul/> id or class control #8

Closed johncblandii closed 12 years ago

johncblandii commented 12 years ago

https://github.com/techiferous/tabulous/blob/master/lib/tabulous/tabulous.rb

Line 23 could allow for the inclusion of an id or class so we can control the UI. In my current case, I want to use Twitter Bootstraps "secondary-nav" to push these to the right of my "topbar". If it is possible, let me know. If not, it would be a welcomed addition. :)

techiferous commented 12 years ago

Fabulous idea. I like it. I'll add it to my list of improvements that I want to make to tabulous. However, don't necessarily expect a tabulous update soon (it'll probably be months, not weeks) so in the meantime you may want to work around this yourself.

johncblandii commented 12 years ago

I'm a Rails noob but may try to dig in there and get'er done. :)

Thanks!

On Jan 17, 2012, at 2:05 PM, Wyatt Greene wrote:

Fabulous idea. I like it. I'll add it to my list of improvements that I want to make to tabulous. However, don't necessarily expect a tabulous update soon (it'll probably be months, not weeks) so in the meantime you may want to work around this yourself.

Reply to this email directly or view it on GitHub: https://github.com/techiferous/tabulous/issues/8#issuecomment-3534693

techiferous commented 12 years ago

Well, this should be a great learning opportunity. :) I'm more than happy to help you if you get stuck (or if you need help figuring out how to get started). Feel free to email me directly at techiferous@gmail.com.

johncblandii commented 12 years ago

Will do.

Thanks!

On Jan 17, 2012, at 2:08 PM, Wyatt Greene wrote:

Well, this should be a great learning opportunity. :) I'm more than happy to help you if you get stuck (or if you need help figuring out how to get started). Feel free to email me directly at techiferous@gmail.com.

Reply to this email directly or view it on GitHub: https://github.com/techiferous/tabulous/issues/8#issuecomment-3534767

johncblandii commented 12 years ago

Closing. Forked code and added a pull request.

https://github.com/techiferous/tabulous/pull/9