search

techiferous / tabulous

Easy tabbed navigation for Rails
Other
322 stars 35 forks source link

Added use_wrapper, wrapper_id, and container_class options #9

Closed johncblandii closed 12 years ago

johncblandii commented 12 years ago

use_wrapper breaks Tabulous' CSS completely by removing the div or nav wrapper but allows this to work with any custom CSS or frameworks like Bootstrap.

wrapper_id allows you to change the default wrapper id from tabs to anything you want.

container_class sets the class on the ul element, if it isn't empty.

Example, to use with Boostrap: config.use_wrapper = false config.container_class = "pills"

This changes my main nav to use Bootstrap CSS solely and the 'pills' class on the ul.

techiferous commented 12 years ago

Cool, thank you! I want to take some time in the future to do a significant upgrade to tabulous and its API (if I ever get the time) so I'm going to hold off on pulling in this API change for now but will definitely keep this use case in mind when I upgrade tabulous.

johncblandii commented 12 years ago

Cool. No worries. I look forward to the upgraded version. Thx for pushing me to try to make the changes. :) It was a good learning lesson.

techiferous commented 12 years ago

Tabulous now supports Twitter Bootstrap version 2.

johncblandii commented 12 years ago

Awesome! I see you added a custom ul property. Good stuff.

techiferous commented 12 years ago

Thanks!