techjoomla / com_api

API framework for Joomla
http://docs.techjoomla.com/joomla-rest-api/com-api-introduction
GNU General Public License v3.0
123 stars 97 forks source link

Applied versioning code to set path in com_api (resource.php) library… #14

Closed amolkisan closed 6 years ago

amolkisan commented 9 years ago

… itself

This is to set resource path if there is version provided in API url.

coolbung commented 9 years ago

Can you apply code formatting and make sure the code passes PHPCS validation. Also the type for the version should be float, currently is CMD (default)

amolkisan commented 9 years ago

I have added only 4 lines and they are well formatted. I didn't get what you want me to do for code formatting. Used online code sniffer, that doesn't give me major errors. Also when I am using type FLOAT then if version contains value 1.0, it returns only 1, So I removed it.

thite-amol commented 6 years ago

Closing this PR. New discussion is opened under https://github.com/techjoomla/com_api/issues/64

cc @coolbung