search

techmatters / soil-id-algorithm

GNU Affero General Public License v3.0
1 stars 0 forks source link

bug: `list_soils` sometimes returns empty strings for site description #120

Closed shrouxm closed 1 month ago

shrouxm commented 2 months ago

Description

The list_soils function sometimes returns empty strings for soil series descriptions.

Steps To Reproduce

Query list_soils with the coordinates {"lat": 37.140904, "lon": -121.427414}.

Expected behavior

Returned soil series should all have descriptions.

Actual behavior

Some descriptions are missing.

CourtneyLee333 commented 2 months ago

I see this issue for every soil I've seen so far except for 1, out of about 30 soils I've looked at.

shrouxm commented 2 months ago

@CourtneyLee333 good point, i bumped the priority on this & will see if @jjmaynard can fix it

DerekCaelin commented 1 month ago

Jon finished this, sent to paul for review.

paulschreiber commented 1 month ago

@DerekCaelin this was deployed today.

CourtneyLee333 commented 1 month ago

@DerekCaelin Has anyone tested this? Do we have a process for someone checking to make sure bugs are actually fixed?

DerekCaelin commented 1 month ago

I was able to get soil descriptions at 37.140904, -121.427414.