techmatters / terraso-mobile-client

A React Native project for Terraso’s LandPKS mobile application.
https://landpks.terraso.org
GNU Affero General Public License v3.0
2 stars 0 forks source link

BulletList inside a Text component fails to wrap text on Android #1173

Closed knipec closed 1 month ago

knipec commented 4 months ago

On Android, on Soil Texture screen, text in bullet points should wrap.

Ultimately this seems to be a problem with the following nesting:

<Text>
  <Column>
    <Text> this text won't wrap </Text>
  </Column> 
</Text>

Solution options:

  1. Paul suggested looking into: https://github.com/jsamr/react-native-li (slack)
  2. A workaround could be to just stop using the BulletList as an item within the components prop to the component -- because the component requires being wrapped by \.

Image

knipec commented 1 month ago

@tm-ruxandra @CourtneyLee333 I'm guessing not but just in case... Do you consider this part of the components work?

tm-ruxandra commented 1 month ago

@knipec I think it is -- we already have work for typography components, could handle this by making bulleted lists as another one. (I think that would be a good idea regardless since bulleted lists need to be their own component regardless).

CourtneyLee333 commented 1 month ago

Ah, okay, I didn't realize we need a component for lists. I'll make an issue for bulleted and numbered lists.

CourtneyLee333 commented 1 month ago

Closing as this will be done in the component work. Here's the design issue for it