Location and Soil Properties Info Sheets on Soil Info Sheet open too tall and X button does not work

techmatters / terraso-mobile-client

A React Native project for Terraso’s LandPKS mobile application.

https://landpks.terraso.org

GNU Affero General Public License v3.0

2 stars 0 forks source link

Location and Soil Properties Info Sheets on Soil Info Sheet open too tall and X button does not work #1651

Closed CourtneyLee333 closed 2 months ago

CourtneyLee333 commented 3 months ago

This appears to be the same issue we had the previous implementation of the Data Privacy sheet.

knipec commented 3 months ago

Triage notes:

Components work is going to touch overlay sheets. Prefer to fix this via components work (#697), and not need this fix for Capri

paulschreiber commented 3 months ago

@knipec can web fix the close button now and the sheet later?

knipec commented 3 months ago

@paulschreiber I'd imagine so, but not sure quite what it'd involve (@tm-ruxandra can chime in if she knows more). We marked it a P2 because we think it's nice-to-have but not a P1 for Capri because you can swipe the sheet down instead of pressing the X.

tm-ruxandra commented 3 months ago

@paulschreiber @knipec the issue is that the sheet's unexpected height causes the close button to be out of tapping range for users on some devices. I can poke around to try and find a good fix.

paulschreiber commented 2 months ago

Please verify in 168.

DerekCaelin commented 2 months ago

This looks good to me. Over to @CourtneyLee333, who filed the issue.

CourtneyLee333 commented 2 months ago

This passes for me too!