Site name in app bar updates before "Save" button is pressed

knipec commented 3 months ago

The site name in the app bar updates as the user edits the name field, rather than after the save button is pressed.

Steps to reproduce

The site name in the green app bar at the top doesn't change until after you press Save

The site name appears to update in the app bar as you type. But it's not officially updating the real site name until you press Save.

Carissa: I find this kind of confusing because I'd expect the app bar site name to be the real site name. https://github.com/techmatters/terraso-mobile-client/assets/5590815/c67d3eab-4e7e-41aa-a24d-e5c2824019ac
Courtney: The name in the app bar should not update until Save.
Ruxandra: not an element of component work

paulschreiber commented 3 months ago

The current behaviour is fine.

DerekCaelin commented 2 months ago

Curious about @CourtneyLee333's opinion about this issue

CourtneyLee333 commented 2 months ago

I agree with Carissa's assessment. The name in the app bar should not update until Save.

knipec commented 2 months ago

@CourtneyLee333 @tm-ruxandra Do you consider this part of the components library work / part of #1784 ?

tm-ruxandra commented 2 months ago

@knipec I wouldn't, this seems like a bug with flow of data not the component itself.

DerekCaelin commented 2 months ago

Edited title and description, looking forward to triaging

knipec commented 1 month ago

Triage notes:

We think the desired behavior exists in the app for editing a project. Wonder if there's a difference in Formik usage.