feat: when we do not have access to user location, load the map in a more sensible location

techmatters / terraso-mobile-client

A React Native project for Terraso’s LandPKS mobile application.

https://landpks.terraso.org

GNU Affero General Public License v3.0

2 stars 0 forks source link

feat: when we do not have access to user location, load the map in a more sensible location #1886

Open shrouxm opened 2 months ago

shrouxm commented 2 months ago

currently when the user has not granted location permission, the map loads in some fixed default position. we could improve on this by either:

if the user has sites, zoom to a bounding box that covers their sites
use the user's IP address to get a rough location estimate? (idk how reliable this is)

Chosen Solution

If User has not provided permissions.
- IF user has sites: Zoom to bounding box containing the users sites. (default behavior for Terraso data maps, Jose could be a useful resource there)
- IF user has no sites: latlong 0,0, minimum zoom

paulschreiber commented 2 months ago

knipec commented 1 month ago

Triage notes:

Assigning to derek to flesh out the desired behavior (maybe zoom to sites if they have sites; what to do if not?)
There are some free IP geolocation libraries we could look into (though do we want to even center over anything specific to their location if they have denied location permissions?)

DerekCaelin commented 3 weeks ago

@CourtneyLee333 what do you think of this solutuon:

User has not provided permissions.

IF user has sites: Zoom to bounding box containing the users sites. (default behavior for Terraso data maps, Jose could be a useful resource there)
IF user has no sites: latlong 0,0, minimum zoom

CourtneyLee333 commented 3 weeks ago

I think that's perfect, and matches what I'd thought of as well.

paulschreiber commented 3 weeks ago

0,0 is a bad spot. It's in the Atlantic Ocean. We should center on the middle of their country (IP geolocation?) or the center of the US.

DerekCaelin commented 3 weeks ago

0,0 at min zoom shows a large portion of the globe. Defaulting the U.S. wont work for global users. If users don't consent to sharing device location, I don't think we should look up their location, even approximate, via IP.