Somehow I set an impossible color that crashes if you try to view it

[knipec]

App Version

1.0.1 (182)

Account

No response

Platforms

• [X] iOS
• [X] Android
• [ ] iOS simulator
• [ ] Android emulator

Description

App crashes when navigating to the color screen. But I think only when the color has been set is kinda invalid (see "Additional context")

Steps to Reproduce

1. Go to Projects and click on the project "Test project cknipe 2024-07-23". (I added everyone on the team as viewers)
2. Go to the Sites tab and click on the site "Crash on soil color screen"
3. Go to the site's Soil tab and click on the "Soil Color" for the first depth interval that has data

Expected behavior

You see the soil color screen

Actual behavior

Crash

Additional context

• The color that causes the crash question is "10RP 2.5/6" -- I have no idea how I got that color.
  • I suspect the bug is because of the weird color, and I'm not sure how it was able to be set. "RP" is not a Hue dropdown option when creating a new soil.
  • I created that color data in version 182 using the dropdowns (not the camera), and now am looking at the Hue dropdown in version 183, but I went back to commit b98fff3 (tagged v182beta) and it doesn't look like anything related changed between those versions?
  • However, "10RP" does appear in a file "terraso-backend/Data/LandPKS_munsell_rgb_lab.csv" so maybe it should be a valid option??
• The other color ("5PB 2.5/1") does not cause a crash

[DerekCaelin]

I have tried all different combos of this and I can't repro! Very mysterious.

This is a P1 (crash!) but I'm not sure if we can tackle if we don't know how to repro. @shrouxm do you have an opinion?

[knipec]

Paul pointed out there are two things we can do here:

1. Don't crash if you do run into a weird color (we can tackle this -- but also makes me wonder if there's a more general solution we want to implement rather than a one-off for this)
2. Don't allow a weird color (don't know how to tackle)

[knipec]

Triage notes:

• @knipec to find the data stored in django admin
• Fix Issue 1, and maybe garo can take a look at Issue 2 (from comment above) but timebox that

[shrouxm]

as far as i understand things:

• the only way to set that color really should be via the photo workflow (the set of options for the hue dropdown is set to a constant array that does not include RP)
• once you set a color via the photo workflow, the only way to view the dropdowns for the site should clear the values

but it seems you're saying you were able to set that color via the dropdowns?

re point 1, the crash could be in the validProperties function in soilColorValidation.ts where we try to index the SOIL_COLORS table by hue, and SOIL_COLORS does not include RP

i don't know how to address point 2 without being able to reproduce and am not sure how to reproduce

[DerekCaelin]

I think this is a lower priority if we're having trouble reproducing... keeping open, but dropping it down to a medium. It seems "very bad, but extremely uncommon"