techmatters / terraso-mobile-client

A React Native project for Terraso’s LandPKS mobile application.
https://landpks.terraso.org
GNU Affero General Public License v3.0
2 stars 0 forks source link

Warning when navigating to site: "Warning: A props object containing a "key" prop is being spread into JSX" #2223

Open tm-ruxandra opened 1 week ago

tm-ruxandra commented 1 week ago

Steps to repro: 1) Open application in developer mode 2) Navigate to any site 3) Observe the following error onscreen:

 ERROR  Warning: A props object containing a "key" prop is being spread into JSX:
  let props = {key: someKey, position: ..., route: ..., navigationState: ..., getAccessibilityLabel: ..., getAccessible: ..., getLabelText: ..., getTestID: ..., renderBadge: ..., renderIcon: ..., renderLabel: ..., activeColor: ..., inactiveColor: ..., pressColor: ..., pressOpacity: ..., onLayout: ..., onPress: ..., onLongPress: ..., labelStyle: ..., style: ..., defaultTabWidth: ..., android_ripple: ...};
  <TabBarItem {...props} />
React keys must be passed directly to JSX without using spread:
  let props = {position: ..., route: ..., navigationState: ..., getAccessibilityLabel: ..., getAccessible: ..., getLabelText: ..., getTestID: ..., renderBadge: ..., renderIcon: ..., renderLabel: ..., activeColor: ..., inactiveColor: ..., pressColor: ..., pressOpacity: ..., onLayout: ..., onPress: ..., onLongPress: ..., labelStyle: ..., style: ..., defaultTabWidth: ..., android_ripple: ...};

TabBarItem seems to be somewhere upstream of our navigation system; is it possible that some updated dependency made our usage invalid?

Screenshot 2024-10-01 at 2 39 48 PM
knipec commented 1 week ago

Triage notes:

semihyagli commented 1 week ago

When will this be released? I see that the latest release was on July 25 and this PR was just merged last week.

tm-ruxandra commented 10 hours ago

@semihyagli We are not the maintainers of the react navigation library, this is just a project which was affected by the issue. Please direct your questions regarding the issue to their repository.