techmatters / terraso-product

Non-engineering tasks or tasks that have significance across repos in Terraso.
0 stars 0 forks source link

Research - revise names listed in required inputs and soil tabs? #1079

Closed DerekCaelin closed 1 month ago

DerekCaelin commented 1 month ago

Currently we use the same name for inputs on the required inputs list and the inputs listed on the soil tab. Is the use of the word "Soil" redundant in the context of the soil tab? Should we name things differently on the required data inputs list and the soil tab? EG ("Soil Color" on required data inputs and "Color" on the soils tab).

Conclusion

image image

Acceptance Criteria

CourtneyLee333 commented 1 month ago

@DerekCaelin The redundancy doesn't bother me, and I'd say there is a decent case for the word "soil" being helpful in this context. Since it's already implemented with one string for each input that gets pulled in the various places, let's leave it until we have a good reason to make a change. I like consistency.

DerekCaelin commented 1 month ago

Sounds good to me. FYI @paulschreiber

DerekCaelin commented 1 month ago

Courtney, re: this issue: https://github.com/techmatters/terraso-mobile-client/issues/2225

Should we call the Soil Texture observation Soil Texture Class?

CourtneyLee333 commented 1 month ago

That seems like a decision for engineering to make. I don't think we will have another texture input in the future (plant texture?) so it should be obvious in the code that it is soil texture. If they want to change to keep us on the same page, cool cool.