techmatters / terraso-product

Non-engineering tasks or tasks that have significance across repos in Terraso.
0 stars 0 forks source link

Soil depth intervals - Part 1 #157

Closed ltseng closed 3 months ago

ltseng commented 1 year ago

User Story

### Design
- [ ] https://github.com/techmatters/terraso-product/issues/205
- [ ] https://github.com/techmatters/terraso-product/issues/206
### Front end
- [ ] https://github.com/techmatters/terraso-client-shared/issues/11
- [ ] https://github.com/techmatters/terraso-mobile-client/issues/456
- [ ] https://github.com/techmatters/terraso-mobile-client/issues/381
- [ ] https://github.com/techmatters/terraso-mobile-client/issues/502
- [ ] https://github.com/techmatters/terraso-mobile-client/issues/975
### Back end
- [ ] https://github.com/techmatters/terraso-backend/issues/622

Acceptance criteria

Custom soil depth intervals Test cases

### Bugs
- [ ] https://github.com/techmatters/terraso-mobile-client/issues/504
- [ ] https://github.com/techmatters/terraso-mobile-client/issues/943
### Out of Capri
CourtneyLee333 commented 1 year ago

@ltseng I wonder - can the project manager decide whether or not the contributor can add more intervals? Or, does the contributor always have the option to add intervals that are outside of the required intervals?

And, don't we have a scenario where a contributor or manager can determine the intervals per site, and override presets, when they encounter soil horizons that are different than the presets?

ltseng commented 1 year ago

The contributor can always add more intervals on a per-site basis for sites that are unaffiliated or are part of projects. In both cases, the contributor can only add intervals that do not overlap with any other custom ones that have been defined, whether by the project manager or by another project/site contributor.

The scenario you mentioned is covered partially by the specified functionality. I say partially because it only works for the case where project managers have created custom depth intervals for part of the possible 0-200 cm range (say, 0-25 and 25-30), but the project contributor wants to record observations for the uncovered depths (30-200).

What is not covered is the scenario where the project contributor wants to modify the depth intervals set by the project manager, but only for their given site. So, in the previous example, they would not be able to change it to 0-10 cm and 10-30 cm, for example. I'm not entirely sure how to make that work. I'm also not sure how common this scenario would be.

If this is a common scenario, perhaps we need to propose a new requirement - if the project manager hasn't specified any depth intervals at the project level, the any project manager or contributor can choose to override the standard default depth intervals (i.e. LandPKS and NRCS) and use custom depth intervals per site. But that seems potentially tricky to design.

What are your thoughts, @CourtneyLee333?

CourtneyLee333 commented 1 year ago

I also don't know how common or significant the scenario will be where the soil horizons are different from the pre-set intervals. I've included some questions about this in the notes for the next BLM meeting.

ltseng commented 10 months ago

@david-code and @ajabeckett -

@CourtneyLee333 and I conferred and made the following changes, which should be reflected in the user story above:

Image

Image