techmatters / terraso-product

Non-engineering tasks or tasks that have significance across repos in Terraso.
0 stars 0 forks source link

Input soil color data #160

Closed ltseng closed 2 months ago

ltseng commented 1 year ago

A critical component of the data inputs that help to determine SoilID.

References

Spec - Soil Color

### Design
- [ ] https://github.com/techmatters/terraso-product/issues/210
- [ ] https://github.com/techmatters/terraso-product/issues/211
- [ ] https://github.com/techmatters/terraso-product/issues/572
### Front end
- [ ] https://github.com/techmatters/terraso-mobile-client/issues/129
- [ ] https://github.com/techmatters/terraso-client-shared/issues/10
- [ ] https://github.com/techmatters/terraso-mobile-client/issues/1115
- [ ] https://github.com/techmatters/terraso-mobile-client/issues/974
- [ ] https://github.com/techmatters/terraso-product/issues/729
### Back end
- [ ] https://github.com/techmatters/terraso-backend/issues/623
### QA
- [ ] https://github.com/techmatters/terraso-product/issues/644
- [ ] https://github.com/techmatters/terraso-mobile-client/issues/1352
- [ ] https://github.com/techmatters/terraso-mobile-client/issues/1319

Additional Context

Note from Laura: Note: engineers, please note that there are some technical discussions that Courtney and I would like to have before you start any technical work here.

Acceptance criteria

CourtneyLee333 commented 1 year ago

@ltseng Can you provide more detail for "If I chose to provide manual data for a site, I should be asked if I want to provide manual data for the other soil depths for the site."?

ltseng commented 1 year ago

It's a direct carryover from the current app. When a user chooses to use manual input for the first time to provide soil color for a single depth, they are asked if they want to switch to manual inputs for the other depths. If they agree, then they don't need to manually toggle over to manual input for the other depths. If they disagree, then the other depths will show the guided experience with selecting a color reference, sample size, and points on their photo.

CourtneyLee333 commented 1 year ago

Thanks!

ltseng commented 1 year ago

Courtney and I discussed a better workflow for this today, where the default for soil color input is manual, but users can select a "Guide me" option to go through the photo upload/identification process. As a result, I have removed the requirement above for "If I chose to provide manual data for a site, I should be asked if I want to provide manual data for the other soil depths for the site."

For photo upload, it would be nice to be able to reorder some of the steps, i.e. upload/take photo first, then choose sample size, as well as to be able to modify both the soil and color reference selections after initial selection (currently you can only modify the soil bounding box). We also discussed needing to be able to start over at more points during the process, along with consolidating the help text. Add clear edit and save functions for the manual entry.

Ideally for sample size, TBD based on conversation with engineering, it would be great if people could just draw the boxes on the photo directly

CourtneyLee333 commented 1 year ago

Also, perhaps it's better to force the lighting and moisture requirements, rather than ask if they were met. TBD, waiting on Laura's answers to this on the spec.

ltseng commented 1 year ago

@shrouxm and @david-code when we get to building the soil color guide, keep in mind that this will ideally be built as a reusable component that can be later called from the Toolbox

DerekCaelin commented 2 months ago

Closing since this is released. We have done QA and logged errors, and will follow up with Shawn Salley on the color experience.