search

techmatters / terraso-product

Non-engineering tasks or tasks that have significance across repos in Terraso.
0 stars 0 forks source link

Update to Redux 2.x #563

Open DerekCaelin opened 6 months ago

DerekCaelin commented 6 months ago

Update Shared Client and Web Client to support Redux 2.x. Currently, these fail TypeScript validation:

https://github.com/techmatters/terraso-client-shared/pull/286 https://github.com/techmatters/terraso-web-client/pull/1528

From Garo in https://github.com/techmatters/terraso-client-shared/issues/239:

all the redux packages just got a major version bump with breaking changes. we should validate that upgrading them doesn't introduce any bugs to either the web or mobile client, and upgrade the versions in all 3 repos at the same time. the web client especially should get extra validation since we don't have TS to catch any bugs at build time

DerekCaelin commented 5 months ago

In upgrade, they are hiding some implementation details we are using to customize our implementation. Dependent on Garo's PR to Redux. https://github.com/reduxjs/redux-toolkit/pull/4289

josebui commented 1 month ago

This still needs more work, not sure how much of the https://github.com/techmatters/terraso-client-shared/blob/main/src/store/store.ts needs to be changed since some types seems to be defined differently the last import I was not able to get is ToolkitStore and it also seems that Middleware has changed.