techmatters / terraso-product

Non-engineering tasks or tasks that have significance across repos in Terraso.
0 stars 0 forks source link

Design task - design loading indicator when waiting for a server response #726

Closed DerekCaelin closed 2 weeks ago

DerekCaelin commented 2 weeks ago

Design an indicator to display whenever the app is waiting for the server to respond. See parent task for details.

DerekCaelin commented 2 weeks ago

Closing as duplicate of https://github.com/techmatters/terraso-product/issues/525

DerekCaelin commented 2 weeks ago

Not actually a duplicat of #525

CourtneyLee333 commented 2 weeks ago

@DerekCaelin The loading indicator is already implemented with a basic style of using LandPKS green. I thought we agreed that was good enough and nothing more needs to be designed.

DerekCaelin commented 2 weeks ago

@CourtneyLee333 I'm trying to find a reference for the implementing engineer to insert. I know @shrouxm knows what to expect, but they might not be the implementer. Is https://mui.com/material-ui/react-progress/ enough, do you think?

CourtneyLee333 commented 2 weeks ago

In my understanding the component exists in the app already, and it needs to be implemented on the login screen at this point. I haven't seen it so I don't know what it looks like. But I don't think it needs to be designed.

DerekCaelin commented 2 weeks ago

I'll consider this done then