search

techmatters / terraso-web-client

A React project that powers the frontend of Terraso platform.
https://app.terraso.org/
GNU Affero General Public License v3.0
11 stars 3 forks source link

One-click unsubscribe for non-logged-in-users #837

Closed DerekCaelin closed 1 year ago

DerekCaelin commented 1 year ago

Description

User who is not logged into Terraso should have a one-click unsubscribe from emails experience.

Steps to Replicate

  1. User: request access to closed group
  2. Manage: receive email notification of request
  3. (be logged out of Terraso)
  4. Click "unsubscribe"
  5. See issue

Actual Behavior

See login screen for terraso. Select authentication method. Log in and see snack bar notification (unsubscribed).

Expected Behavior

View screen that confirms unsubscribe (no additional clicks).

image
paulschreiber commented 1 year ago

This is blocked by general public view work: https://github.com/techmatters/terraso-backend/pull/379

DerekCaelin commented 1 year ago

@paulschreiber if #379 is addressed, will this issue be resolved, or will additional work be needed?

I am wondering if we can push #824 without #837 and follow up later in the sprint.

paulschreiber commented 1 year ago
DerekCaelin commented 1 year ago

Eep! Yes, I think I meant the backend #379.

OK, let's plan to release #824 without #837 and follow up.

paulschreiber commented 1 year ago

@DerekCaelin This is done and staged.

DerekCaelin commented 1 year ago

I encounter an error:

Error unsubscribing from Terraso emails

Steps to reproduce (Chrome: Version 112.0.5615.49 (Official Build) (arm64)

  1. non-manager - request to join closed group
  2. manager - receive email
  3. manager - copy unsubscribe link to incognito window
  4. See error
paulschreiber commented 1 year ago

Here's the error JSON:

{"data":{"unsubscribeUser":{"errors":[{"message":"
[{"message": "You must be authenticated to perform this operation", "code": "unauthorized"}]"}]}}}
paulschreiber commented 1 year ago

This should be working now. commons.py was not correctly deployed to staging.

DerekCaelin commented 1 year ago

Confirmed! Please push to prod!