search

techmeetup / edinburgh

Organisational things for TechMeetup Edinburgh
14 stars 4 forks source link

Techmeetup Edinburgh OpenTechCalendar feed problem #34

Closed MariusCiocanel closed 10 years ago

MariusCiocanel commented 10 years ago

It seems that http://techmeetup.co.uk/edinburgh.html is showing a techmeetup event for 15 Oct 2014. It seems to be deleted on the OpenTechCalendar website but still comes through the feed. This one is for @jarofgreen :)

jarofgreen commented 10 years ago

If you look at http://opentechcalendar.co.uk/index.php/group/1/jsonp?callback=OpenTechCallBackFunction1 - that being the JSONP used to load the data you'll notice the first event has a deleted flag set. Basically the site isn't checking for that. If you edit https://github.com/techmeetup/techmeetup.co.uk/blob/gh-pages/static/js/cityCal.js and check for this. So

html += htmlFromEventOpenTechCalendarEventList(data.data[i], usingOptions.maxStringLength, target);

Could become

if (!data.data[i].deleted) {
html += htmlFromEventOpenTechCalendarEventList(data.data[i], usingOptions.maxStringLength, target);
}

That's of the top of my head, ideally check locally first. Or just push and see, live dangerously ....

MariusCiocanel commented 10 years ago

That worked. Thanks :)

jarofgreen commented 10 years ago

Thanks for picking that up, swamped with work at the moment!