search

techmilldenton / hackntx

Static site for Hack NTX
https://www.hackntx.com
0 stars 6 forks source link

Notifications system #55

Closed sffitzpatrick closed 6 years ago

sffitzpatrick commented 6 years ago

addresses #50

This is a basic system to show alerts or modals to users based on a URL query param. These alerts or modals are populated in _data/notifications.yml and output as json for the script to read and render appropriately.

You can test with ?notification=paypal and ?notification=thankyou

kyletaylored commented 6 years ago

AWESOME. I have a few minor changes for compatibility, so when you get a chance, can you check "Allow edits from maintainers" in the sidebar on this PR so I can push directly to it?

https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/

sffitzpatrick commented 6 years ago

@kyletaylored "allow edits" is checked and I noticed it looked like you pushed merged in master earlier... but maybe because it's a PR from my fork you can't push directly? What if we merge this as a branch on the techmill repo so you can make the changes directly?

kyletaylored commented 6 years ago

Got it, I just did a quick merge locally.

Closes #50