search

technicalpickles / jeweler

Opinionated tool for creating and managing Rubygem projects
MIT License
1.48k stars 164 forks source link

rake release accepts remote and branches #249

Closed emilsoman closed 11 years ago

emilsoman commented 11 years ago

rake release accepts remote(default: origin), local branch (default: master) and remote branch(default: master)as optional arguments.

$ rake release[upstream,critical-security-fix,v3]

This will tag and push the commits on your local branch named critical-security-fix to branch named v3 in remote named upstream (if you have commit rights on upstream) and release the gem. This is useful in scenarios where releases keep happening from older version branches, like in Rails.

emilsoman commented 11 years ago

@technicalpickles , what do you think ? Should be able to close #207 if this goes in.

technicalpickles commented 11 years ago

Good use of rake args! My only concern would having it be multiple un-named arguments. I feel like I'd have to look up the correct order every time, and even then would probably make mistakes still.

emilsoman commented 11 years ago

Good point. How about using ENV, that would let us do something like rake release REMOTE=origin LOCAL_BRANCH=branch REMOTE_BRANCH=branch ?

muratayusuke commented 11 years ago

Good idea! I may want to use same branch name for local and remote branch like rake release BRANCH=v3.

emilsoman commented 11 years ago

@muratayusuke , done

technicalpickles commented 11 years ago

@emilsoman yeah, that would definitely address the issue :+1:

muratayusuke commented 11 years ago

:+1: