search

technicalpickles / jeweler

Opinionated tool for creating and managing Rubygem projects
MIT License
1.48k stars 169 forks source link

introduce coveralls #251

Closed muratayusuke closed 10 years ago

muratayusuke commented 10 years ago

Introduce coveralls and add badge to readme.

technicalpickles commented 10 years ago

For reference, coveralls is https://coveralls.io/:

Coveralls works with your continuous integration server to give you test coverage history and statistics. Free for open source, pro accounts for private repos, instant sign up with GitHub OAuth.

emilsoman commented 10 years ago

This is only for jeweler's own code coverage and not for the gems crafted with jeweler , right ? On 28 Oct 2013 18:56, "Josh Nichols" notifications@github.com wrote:

For reference, coveralls is https://coveralls.io/:

Coveralls works with your continuous integration server to give you test coverage history and statistics. Free for open source, pro accounts for private repos, instant sign up with GitHub OAuth.

— Reply to this email directly or view it on GitHubhttps://github.com/technicalpickles/jeweler/pull/251#issuecomment-27210833 .

technicalpickles commented 10 years ago

@emilsoman looks that way, as there's no changes to the generator.

emilsoman commented 10 years ago

@muratayusuke , I don't think this will fix #189 or #225 . Please update the comment to avoid any confusion and go ahead and merge this.

muratayusuke commented 10 years ago

@emilsoman Wow, I've just understood the problem of above 2 issues, sorry. They said about skeleton made by jeweler, right? As @technicalpickles said, I just show the test coverage of jeweler itself and I fixed the description of this pr.

nickserv commented 10 years ago

It seems like this pull request caused build 53 to fail on Ruby 1.8. Additionally, it seems like coveralls isn't working properly because the Travis build is failing.

I recommend to either disable coveralls on Ruby 1.8 or remove Ruby 1.8 from travis.yml (which I think is important, as it is now officially deprecated).

muratayusuke commented 10 years ago

@thenickperson Oops, sorry. It's time to remove Ruby 1.8 and bump up major version. It will also fix some other problems. I'll do that.

nickserv commented 10 years ago

@muratayusuke Great, thank you. I just wasn't sure if the transition away from Ruby 1.8 was happening soon or not.

muratayusuke commented 10 years ago

@technicalpickles I can't get token of coveralls for this repository. Would you login to coveralls and tell me your token?

When you access here after login, you will see REPO TOKEN like this.

muratayusuke commented 10 years ago

@thenickperson I've released new version without Ruby 1.8. Thank you for reporting this problem.

technicalpickles commented 10 years ago

@muratayusuke AhkOkfc0MYCOqb24btF6YAac7cpKcm1Fw

muratayusuke commented 10 years ago

@technicalpickles Thank you, I've updated!