fix: obsolete SAFE level breaking gem on ruby 2.3.0

technicalpickles / jeweler

Opinionated tool for creating and managing Rubygem projects

MIT License

1.48k stars 164 forks source link

fix: obsolete SAFE level breaking gem on ruby 2.3.0 #279

Closed mihael closed 8 years ago

mihael commented 8 years ago

hi jeweler,

this pull should fix issue #278

levels 2-4 are obsolete... 1 should be "safe" enough, according to http://phrogz.net/programmingruby/taint.html

some related info on SAFE 2-4 being removed: https://bugs.ruby-lang.org/issues/8468 https://bugs.ruby-lang.org/issues/11908

enjoy

technicalpickles commented 8 years ago

I'm not sure why, but this is failing on both ruby 1.9.2 and 1.9.3. If you can track down why, I'm happy to add you as a contributor.

mihael commented 8 years ago

quick scan reveals it does not seem to be failing because of the fix, it fails installing jeweller for some reason...

NoMethodError: undefined method `spec' for nil:NilClass
An error occurred while installing
jeweler (2.0.1), and Bundler cannot
continue.
Make sure that `gem install jeweler -v
'2.0.1'` succeeds before bundling.

but def. can take another look later...

skull-squadron commented 8 years ago

There are two issues:

1.9.2: The i18n gem requires 1.9.3 or higher, and it's an obsolute Ruby that's not supported anymore (no security patches outside of some system packages).
1.9.3: A known issue with old bundler on travis.

Fixed in #281

leifcr commented 8 years ago

For 2.3 and newer, 'juwelier' works fine: https://github.com/flajann2/juwelier

@steakknife perhaps you should talk to @flajann2 to work on that fork? Or @technicalpickles could reference that fork in the readme for 2.3 users?

technicalpickles commented 8 years ago

I'm happy to add anyone as contributors or change the canonical repository to a fork for anyone that wants to take over jeweler, as I haven't used or contributed to it in some time.

On Mar 18, 2016, at 10:17 AM, Leif Ringstad notifications@github.com wrote:

For 2.3 and newer, 'juwelier' works fine: https://github.com/flajann2/juwelier

@steakknife perhaps you should talk to @flajann2 to work on that fork? Or @technicalpickles could reference that fork in the readme for 2.3 users?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

technicalpickles commented 8 years ago

I filed https://github.com/technicalpickles/jeweler/issues/283 about the future of jeweler.