search

technicalpickles / jeweler

Opinionated tool for creating and managing Rubygem projects
MIT License
1.48k stars 164 forks source link

Fixes $SAFE issue on Ruby 2.3+ and modernizes Travis builds #281

Closed skull-squadron closed 8 years ago

skull-squadron commented 8 years ago

Fixes #278, #279

Credit to @mihael

technicalpickles commented 8 years ago

Thanks for doing this! Do you have any interesting in helping contribute to jeweler in general? If you do, I'd be happy to add you as a collaborator and give you access to the gem.

Otherwise, I can merge and release this later.

skull-squadron commented 8 years ago

Welcome back to the living! Jeweler hasn't seen a release since 2014, so "later" without a specific deadline doesn't sound like a genuine commitment. I'm super crushed at work and a side-project right now, and just did this to fix a friend's build. :( I'll lump in a couple of the other useful commits in, but maybe someone else in one of the open PR's might be interested?

skull-squadron commented 8 years ago

The best I can do right now.

technicalpickles commented 8 years ago

@steakknife thank you for taking time to put together this work, and at least considering the possibility of contributing more. You must be a good friend to dive into fix jeweler to fix their build :grinning: I can appreciate being crushed with work and other life things, as that's what happened to and resulted in being an absentee gem maintainer

I could merge this now, but I don't think that will solve the underlying problem of me not mindfully maintaining this project. I filed https://github.com/technicalpickles/jeweler/issues/283 to figure that out. In the short term, people could consider either using @steakknife's fork, or https://github.com/flajann2/juwelier (I am not sure if it's API compatible yet).

flajann2 commented 8 years ago

I released a new gem with the $SAFE fix in place, but the Travis modernization looks interesting.

flajann2 commented 8 years ago

Can you pull and merge with the latest and resolve the conflicts? Then I'll merge your pull request. Thanks.

flajann2 commented 8 years ago

Resolved the conflicts.

flajann2 commented 8 years ago

All looks good with the merge.