search

technicalpickles / jeweler

Opinionated tool for creating and managing Rubygem projects
MIT License
1.48k stars 164 forks source link

rake install command fails with Rubinius #64

Closed dkubb closed 14 years ago

dkubb commented 15 years ago

The following line of code will fail with Rubinius:

http://github.com/technicalpickles/jeweler/blob/master/lib/jeweler/commands/install_gem.rb#L19

The reason is that Config::CONFIG['RUBY_INSTALL_NAME'] returns the string "rbx", but the code assumes it will be "ruby". A better solution would be to change this line to:

"#{Config::CONFIG['RUBY_INSTALL_NAME']} -S gem"

Which should work with all ruby implementations, regardless of the name of the binary.

technicalpickles commented 15 years ago

That sounds pretty reasonable. If you want to expedite it, patches are certainly welcome :)

dkubb commented 15 years ago

A pull request is on it's way. :)

dkubb commented 15 years ago

I've implemented the fix for this, and also fixed some failing specs in my fork:

http://github.com/dkubb/jeweler

myabc commented 14 years ago

The current implementation also causes problems for installation with JRuby on Windows. There is no jgem.bat script on Windows.

dkubb commented 14 years ago

@myabc: Does the fix I've implemented resolve the JRuby on Windows problems?

myabc commented 14 years ago

@dkubb. Yes, it should do. The only thing I've been trying to check is compatibility with the up-coming IronRuby implementation (which does have an igem script, but I don't see the -S option in its documentation).

myabc commented 14 years ago

For IronRuby support, I chatted with jimmysch and they will look to implement the -S option: http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3290

myabc commented 14 years ago

This is now implemented in IronRuby too! http://twitter.com/jschementi/status/7365249412

technicalpickles commented 14 years ago

This was merged in awhile back.