search

technikhil314 / angular-components

Collection of all my open source angular components
https://github.com/technikhil314/angular-components
MIT License
24 stars 30 forks source link

dates are not clickable #29

Closed pmalikbtech closed 6 years ago

pmalikbtech commented 6 years ago

dates are not clickable and not updated in view

technikhil314 commented 6 years ago

Yes there was a issue that month was not getting updates on left calendar which I resolved in v1.1.36. But I found that dates are clickable. It will be mor helpful if you can provide more insights

pmalikbtech commented 6 years ago

on init every time getting error (ERROR TypeError: Cannot read property 'startDate' of undefined). but i am passing options having start date and end date. by default its picking up today date in both input fields

technikhil314 commented 6 years ago

@pmalikbtech Can you please post options you are passing to the daterangepicker component. It will help me to figure out what is the exact issue. Thanks

technikhil314 commented 6 years ago

closing the issue as thread is inactive for more than a week. And no other user has raised same issue.

sapanjwani commented 6 years ago

Hey , i think i'm facing the similar issue. Can we sort this out ?

technikhil314 commented 6 years ago

@sapanjwani can you please let me know which browser are you using

sapanjwani commented 6 years ago

Hi Nikhil,

I was using on Chrome , actually , it works good when I give min date and max date in option but else does not .

I was looking into code of daterangepicker-component.ts, you return moment () somewhere , I guess the issue is happening due to checks.

To replicate, give no option , it should work by taking default values of options. But it was not , dates were not clickable .

Regards, Saurabh

On 16-Jun-2018 2:55 PM, "nikhil.001mehta" notifications@github.com wrote:

@sapanjwani https://github.com/sapanjwani can you please let me know which browser are you using

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nikhil-001mehta/angular-2-daterangepicker/issues/29#issuecomment-397800238, or mute the thread https://github.com/notifications/unsubscribe-auth/AVKjbogs0pg_l0rIB9r2eyTk-p0_qCBdks5t9M8CgaJpZM4T06kP .

sapanjwani commented 6 years ago

Hi,

You can reach me @9773671145 in case a discussion is needed , maybe it's something I'm doing wrong , and you could help me out .

Regards, Saurabh

On 16-Jun-2018 3:33 PM, "saurabh panjwani" saurabh110693@gmail.com wrote:

Hi Nikhil,

I was using on Chrome , actually , it works good when I give min date and max date in option but else does not .

I was looking into code of daterangepicker-component.ts, you return moment () somewhere , I guess the issue is happening due to checks.

To replicate, give no option , it should work by taking default values of options. But it was not , dates were not clickable .

Regards, Saurabh

On 16-Jun-2018 2:55 PM, "nikhil.001mehta" notifications@github.com wrote:

@sapanjwani https://github.com/sapanjwani can you please let me know which browser are you using

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nikhil-001mehta/angular-2-daterangepicker/issues/29#issuecomment-397800238, or mute the thread https://github.com/notifications/unsubscribe-auth/AVKjbogs0pg_l0rIB9r2eyTk-p0_qCBdks5t9M8CgaJpZM4T06kP .

technikhil314 commented 6 years ago

@sapanjwani Thanks a lot for pointing out the issue i have fixed the issue in v1.1.43. Let me know if you have any sugestions or facing any issues.