technikhil314 / next-webrtc

An open source, privacy focused, in browser, live screen share and webcam video recorder
https://openrtc.vercel.app/
63 stars 15 forks source link

Update `react-rhino` to latest version #3

Closed aromalanil closed 2 years ago

aromalanil commented 3 years ago

Description

If merged, this PR will

technikhil314 commented 2 years ago

Hey @aromalanil Sorry I just checked your PR. But I have moved to npm from yarn. Can you send me the patch or update the PR. I will merge it.

aromalanil commented 2 years ago

@technikhil314 Yeah sure, I'll change it

aromalanil commented 2 years ago

@technikhil314 The npm workspaces doesn't seems to work. Is it okay to just update the version in packages/fontend

technikhil314 commented 2 years ago

Ohk I ll do it then. I thought some syntax has changed too??

aromalanil commented 2 years ago

Yes. The syntax change is that

aromalanil commented 2 years ago

I have also used the hooks useSetRhinoState & useRhinoValue where it's appropriate for optimisation