search

techninja / cncserver

A RESTful API server for driving serial based CNC devices
133 stars 40 forks source link

Update enable motors commands #138

Closed ghost closed 1 year ago

ghost commented 1 year ago

This PR updates the enablemotors commands in each machine configuration, to avoid a reliance on how the EiBotBoard firmware handles a missing second parameter, which varies across firmware versions. This fixes #137.

oskay commented 1 year ago

Looks good to me!

ghost commented 1 year ago

@oskay What's the process for getting this merged in? Anyone I should be tagging here? I don't have the necessary permissions to merge it myself

oskay commented 1 year ago

@techninja I don't see any issues here. Any objection to merging this?

techninja commented 1 year ago

I wonder if @dtgreene has a free minute to take a look, I haven't had a moment. We'd probably also want to run another release

dtgreene commented 1 year ago

@techninja Looks good to me! I can merge and create a new release