search

techninja / cncserver

A RESTful API server for driving serial based CNC devices
133 stars 39 forks source link

Fix speed calculation function #62

Closed docprofsky closed 9 years ago

docprofsky commented 9 years ago

This will fix an issue in the way the speed calculation function calculates the correct step rate based on a percentage.

This image shows the output of the old function (red), and this version (blue). image

techninja commented 9 years ago

I... think that's right? it's incredibly subtle in actual output, I suppose since this likely has remained untouched since the beginning that's why it's been ignored. We never really go below 10% anyways because 0% is an option, and that would mean "not moving", not "really darn slow" as it actually is. I'll go ahead and merge this because anyone who's willing to put a graph in their PR means business.

Also if it's wrong I'll just make you submit another one :)