search

techninja / cncserver

A RESTful API server for driving serial based CNC devices
133 stars 39 forks source link

Move all controller commands to machine config file #65

Closed docprofsky closed 8 years ago

docprofsky commented 8 years ago

This takes all (all - 1) hardcoded command strings and moves them to the machine config file. The function sendSetup (line 730) still uses a hardcoded string as this is a bit harder to sensibly move into a config file without switching to something more like what was discussed in #64.

techninja commented 8 years ago

In theory, all looks sound. Certainly a bit of low hanging fruit for Hacktoberfest :jack_o_lantern: :beers:!

Disable motors is an obvious flub, but... this leaves the bot specific logic in place at line 355. If that (I think it might be the only one of its kind). If that was also moved to some kind of "Setup Sequence" then I'd consider this a worthy addition... otherwise the discussion at #64 makes more sense to put work into.

OR... putting a setup sequence definition in an ini file is asking too much of it. Hmm.

techninja commented 8 years ago

I'm just going to merge this before I go crazy and make it unmergable.