search

techninja / cncserver

A RESTful API server for driving serial based CNC devices
133 stars 39 forks source link

Fix 'npm test' to run 'mocha' instead of non-existent Gruntfile #67

Closed jleverenz closed 8 years ago

jleverenz commented 8 years ago

package.json includes a test script configured to call 'grunt --verbose'. This appears to be incomplete, as a Gruntfile is not included in this project. Replace with a call to 'mocha' which appears to be the chosen test framework based on contents of package.json and the test directory. Remove grunt package dependencies.

jleverenz commented 8 years ago

Hi. Just getting started with a new watercolorbot, found my way to this project. New to node, so welcome any feedback on whether I'm missing something with this change to get tests running.

techninja commented 8 years ago

Hello there! Yes, unfortunately I haven't had enough time to devote to this project as it deserves, any and all help is definitely appreciated. It's not perfect, through iteration we strive to become better. I'll take a look at this today and hopefully get it merged :)

techninja commented 8 years ago

OK, Turns out I hadn't really fully baked the tests I had, and was in between getting these changes pushed and had configured a gruntfile, but since I have no one checking my work, I had neglected to push it! Whoops. I blame @docprofsky because I can, and it's easy. Just pushed my local grunt file to master, hopefully can get jshint passing and other stuff cleaned up today.

The next big thing is going to be finding out the best way to keep the serial run thread moving smoothly while adding items to the queue.

jleverenz commented 8 years ago

Works for me with your change, thanks! jshint and mocha tests running fine..

docprofsky commented 8 years ago

@techninja Hey!