Refactor serial port auto detection for various platforms and add tests

techninja / cncserver

A RESTful API server for driving serial based CNC devices

133 stars 39 forks source link

Refactor serial port auto detection for various platforms and add tests #68

Closed jleverenz closed 8 years ago

jleverenz commented 8 years ago

Introduces some tests based on the discussion at https://github.com/evil-mad/robopaint/issues/235

techninja commented 8 years ago

Looking at this now....

techninja commented 8 years ago

Beautiful! Thank you for this. So rare to see good things come in like this, one of many low hanging fruit tests ripe for the picking. Hopefully as we move though we can continue to improve and add more tests.

I've commented above, feel free and rebuke or adjust as needed.

techninja commented 8 years ago

This work has mostly been changed/rolled into the new version. check that work and if there's more change's you're looking for, submit a new PR :smile: