techninja / cncserver

A RESTful API server for driving serial based CNC devices
133 stars 39 forks source link

Movements may not work as expected with non-integer inputs #82

Open oskay opened 7 years ago

oskay commented 7 years ago

Scratch API: A user reports that the machine may not be correctly responsive when controlled in scratch/snap if the movement values are non-integer. In other words, that we may need to add an integer cast or rounding to the input values.

Needs verification.

techninja commented 7 years ago

Interesting! Will test, verify and fix.

tieandjeans commented 7 years ago

Hey! That was my issue last year! I don't think the issue was necessarily integer handling in CNCserver, rather generating small moves from WCBlocks that didn't clear the step threshold.

oskay commented 7 years ago

Interesting-- yes, we could do this within WaterColorBlocks, but the API also needs to withstand this input.