Added support for hash_argon2id

technion / ruby-argon2

A Ruby gem offering bindings for Argon2 password hashing

MIT License

229 stars 30 forks source link

Added support for hash_argon2id #26

Closed ankane closed 5 years ago

ankane commented 5 years ago

Hey @technion, this adds support for hash_argon2id, which is used for key derivation.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 128

11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 127:	0.0%
Covered Lines:	187
Relevant Lines:	187

💛 - Coveralls

technion commented 5 years ago

Hi @ankane,

Thanks for this PR. It's well written and includes tests so I have no issue merging it, but I'm just noting I haven't explicitly covered a key derivation use case with this library, doing that level of crypto is probably better served with libsodium etc.

ankane commented 5 years ago

Thanks @technion 👍 That function is all that's needed to do key derivation.