Added support for argon2d hash verification

technion / ruby-argon2

A Ruby gem offering bindings for Argon2 password hashing

MIT License

229 stars 30 forks source link

Added support for argon2d hash verification #29

Closed JoeDupuis closed 5 years ago

JoeDupuis commented 5 years ago

Hi, I am using an existing database that contains some argon2d hash, so I need to be able to verify them.

Added argon2d verify support to the gem.

Wasn't sure where to put my tests. I can move them if need be.

Thanks!

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 141

3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 140:	0.0%
Covered Lines:	191
Relevant Lines:	191

💛 - Coveralls

JoeDupuis commented 5 years ago

Travis crashed on jruby with:

Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    bundler (>= 1.10.5, ~> 1.10) java
  Current Bundler version:
    bundler (2.0.1)
This Gemfile requires a different version of Bundler.
Perhaps you need to update Bundler by running `gem install bundler`?
Could not find gem 'bundler (>= 1.10.5, ~> 1.10)' in any of the relevant
sources:
  the local ruby installation
The command "bin/setup" failed and exited with 6 during .

Maybe we should update bundler 1 to bundler 2?

I had the same problem with ruby 2.6.

Edit: Nevermind, just saw that you do uninstall bundler 2 in .travis.yml and I can't reproduce the crash using jruby locally.

technion commented 5 years ago

Thanks for this pull. I've been going in circles on this crappy jruby Travis issue but it's not your PR that broke it.

JoeDupuis commented 5 years ago

Sorry to bother, but can we push the update to rubygems? I'd like to switch my gemfile back to upstream.

technion commented 5 years ago

@twistedjoe No problems, we were due for a bump. I'm tagging 2.0.2 now.