Closed joshbuker closed 3 years ago
Currently the legacy test isn't included in the minitest suite due to lacking the _test suffix. Additionally, if you add the suffix and run the tests, it appears to be in a failing state due to a missing constant:
_test
1) Error: Legacy#test_legacy_hashes: NameError: uninitialized constant Legacy::PASS 2) Error: Legacy#test_valid_hash_legacy_hashes: NameError: uninitialized constant Legacy::PASS
Are these tests obsolete / ready to be removed entirely?
This is a valid test for legacy hashes. The broken filename meant it didn't detect the missing constant. I've pushed a fix for this.
Thanks for the quick fix @technion!
Currently the legacy test isn't included in the minitest suite due to lacking the
_test
suffix. Additionally, if you add the suffix and run the tests, it appears to be in a failing state due to a missing constant:Are these tests obsolete / ready to be removed entirely?