search

technion / ruby-argon2

A Ruby gem offering bindings for Argon2 password hashing
MIT License
229 stars 30 forks source link

Rename salt option to hammer home that you should not use it normally #52

Closed joshbuker closed 3 years ago

joshbuker commented 3 years ago

@technion what are your thoughts on this naming scheme?

I think it more clearly conveys the idea that you should not be using it under normal circumstances, although renaming the instance variable to @insecure_salt may be a little overkill.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling c2a3f429aaf0f84fc207fc9e83217bf5f33e4eeb on athix:feature/rename-salt-option into c79362aaf45f032ab9debe9165262ad1eebb885f on technion:master.

technion commented 3 years ago

I do feel we'll never win this one. React has a variable named __SECRET_DOM_DO_NOT_USE_OR_YOU_WILL_BE_FIRED and I've found it in use in production. Your name works though.

joshbuker commented 3 years ago

Yeah, unfortunately you can only do so much to prevent people from shooting themselves in the foot.