search

techniq / mui-downshift

Thin layer over paypal's downshift to use Material UI visual components
https://techniq.github.io/mui-downshift/
MIT License
92 stars 24 forks source link

Feature Request: Accept other css units on MenuHeigth prop #53

Open gsasouza opened 6 years ago

gsasouza commented 6 years ago

Will be good if we can define MenuHeigth in differents css units. vh and vw for example will improve menu resposivity.

techniq commented 6 years ago

@gsasouza This might be difficult currently with the use of react-virtualized as it needs explicit pixel units, although I've considered dropping the use of react-virtualized in the next major version (and re-releasing the current version as mui-virtualized-downshift or similar).

I did this for mui-table 2.0.0, and released 1.0.0 as mui-virtualized-table and documented some of the benefits here (mostly specific to a table, but related). I'm going to going create a new issue to discuss this change (but no timeline when this might be available).

techniq commented 6 years ago

@gsasouza See this comment that might give you a sufficient workaround until (and if) #54 is implemented.