Remove any from types - Githubissues

techniq / mui-table

Improved Material-UI table

https://techniq.github.io/mui-table/

MIT License

45 stars 12 forks source link

Remove any from types #24

Closed BrendonSled closed 5 years ago

BrendonSled commented 5 years ago

Better generic support

techniq commented 5 years ago

@BrendonSled Thanks! Could you do 2 more things with this PR?

Make the types optional to be passed (<T = any>)? It's what I do with my Fetch component as well.
Update to cover the rest of the props? I've been meaning to get to this one but haven't yet. https://github.com/techniq/mui-table/blob/9c728be7114a3153232e6fb1fa0e94d37284faf3/src/index.js#L343-L364

BrendonSled commented 5 years ago

@techniq updated

techniq commented 5 years ago

Thanks. I'm afk for a bit but will merge and publish a release tonight

On Mon, Jan 28, 2019, 3:51 PM Brendon Sled <notifications@github.com wrote:

@techniq https://github.com/techniq updated

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/techniq/mui-table/pull/24#issuecomment-458296298, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK1REFhQE5JEqfACyA6FMz33B83Fviwks5vH2LXgaJpZM4aWfux .

techniq commented 5 years ago

@BrendonSled Published as 2.3.1. Thanks again!