Consider removing lodash.merge

techniq / mui-table

Improved Material-UI table

https://techniq.github.io/mui-table/

MIT License

45 stars 12 forks source link

Consider removing lodash.merge #25

Closed irrvrsl closed 5 years ago

irrvrsl commented 5 years ago

Hello! I've been searching for tiny wrapper around mui table and found your project. It's cool, but I've checked bundle size of your library and saw that around half of it's size(~10kb minified) is lodash.merge package. Maybe you'll consider to replace it with more lightweight functions, such as: merge deepmerge

techniq commented 5 years ago

Sounds reasonable as long as it doesn't break functionality. We could also add a utils function that does this as well.

Could you send a PR with a replacement?

irrvrsl commented 5 years ago

Yes, I can try to replace it, when I'll get home

techniq commented 5 years ago

Merged PR #26 and released as 2.4.0

techniq commented 5 years ago

@irrvrsl Looks to have made a positive impact. Thanks!

https://bundlephobia.com/result?p=mui-table@2.4.1