Closed techniq closed 8 months ago
Actually, you already did it in layerChart
4 days ago: https://github.com/techniq/layerchart/blob/dd55df13282f33665f38a8cd1482678ec9b961b3/packages/layerchart/package.json#L53-L55
PR open for svelte-ux
👍
Actually, you already did it in
layerChart
4 days ago: https://github.com/techniq/layerchart/blob/dd55df13282f33665f38a8cd1482678ec9b961b3/packages/layerchart/package.json#L53-L55PR open for
svelte-ux
👍
Oh yeah, when I removed the package-lock.json
file to fix the Cloudflare build, these kind of issues showed up :). Thanks!
Once we finish PR's #191 and #192 and merge into next
branch/PR, I publish a new svelte-ux@next
release and update the LayerChart design tokens PR / next package and we can see if we need to do anything else.
@jycouet Updated LayerChart to the latest Svelte UX next.9
release which includes these changes. I was a bit surprised prismjs
and sveld
didn't complain when LayerChart is built now, but I'm just realizing we added those as dependencies
and not devDependencies
.
Technically that's right if using the vite plugin (sveld) or the Code
/Preview
components (prism). These both only apply to LayerChart for it's docs, so maybe we're OK because we...
Code
or Preview
. LayerChart currently uses their own copyplugins
directly, it's setup as their own exportSo maybe all is good, I just wanted to make sure we don't inflate the bundle with these.
Speaking of, there is a nice Table excel export util that I currently do not expose because await import('exceljs')
didn't work within that util the last time I tried (I only want to pull that large exceljs
dep when export is requested. Will need to see if vite supports this now (or whatever caused it to error last time).
done
Need to think how this might impact LayerChart (if at all)
Update Svelte UX
prism*
from peer to devfortawesome/*
from peer to devsveld
from peer (already dev)devDepencies
todependencies
due to the vite plugin which is used in LayerChart?Update LayerChart
prismjs
andprism-svelte
as devsveld
? (see above)