techniq / svelte-ux

Collection of Svelte components, actions, stores, and utilities to build highly interactive applications.
https://svelte-ux.techniq.dev/
MIT License
769 stars 43 forks source link

Pass object of classes through Select-like fields to Field instances #419

Closed brandonmcconnell closed 3 months ago

brandonmcconnell commented 3 months ago

This PR does a few things

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 90f9c8f4cbb538347810b8d8ca5be11dfad2d6a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------- | ----- | | svelte-ux | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-ux ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 6:03pm
techniq commented 3 months ago

Related (just tagging)

techniq commented 3 months ago

Thanks @brandonmcconnell. I couldn't spot any regressions. I know in #155 and #245 there was some difficulty, but I think this approach handles it. If you get a minute, could you read through those and see if there is something I'm overlooking. I'm going to go ahead and merge and release as I couldn't spot any regressions. Thanks!

techniq commented 3 months ago

@brandonmcconnell Actually, the classes order should be (see docs):

Is there a reason you changed the order here?

https://github.com/techniq/svelte-ux/pull/419/files#diff-1a2b7f4ea38036f799f83b1e1c468169f4eaf5568691973cb9c006c3995c2c2eR157-R161

brandonmcconnell commented 3 months ago

@techniq Ah, I mistakenly thought that the h-full was meant to override settings, but understanding that the settings are user-set, I can see that was a regression. Quick OR patching this incoming.

brandonmcconnell commented 3 months ago

PR opened: #421