Closed brandonmcconnell closed 3 months ago
Latest commit: 90f9c8f4cbb538347810b8d8ca5be11dfad2d6a9
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
svelte-ux | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 2, 2024 6:03pm |
Related (just tagging)
Thanks @brandonmcconnell. I couldn't spot any regressions. I know in #155 and #245 there was some difficulty, but I think this approach handles it. If you get a minute, could you read through those and see if there is something I'm overlooking. I'm going to go ahead and merge and release as I couldn't spot any regressions. Thanks!
@brandonmcconnell Actually, the classes order should be (see docs):
settings()
classes (context)classes
propclass
propIs there a reason you changed the order here?
@techniq Ah, I mistakenly thought that the h-full
was meant to override settings, but understanding that the settings are user-set, I can see that was a regression. Quick OR patching this incoming.
PR opened: #421
This PR does a few things
adds a function
normalizeClasses
to normalize classes when they can be a string or an object, essentially converting strings to objects (e.g.'p-2'
➞{ root: 'p-2' }
)adds a function
clsMerge
for merging groups of classes without property-by-property consolidationpasses the
classes
objects down to theTextField
component from theSelect
andMultiSelect
componentsfixes a TypeError caused by a faulty ReturnType from
entries()
and removes a related@ts-expect-error