technistguru / MagicaVoxel_Importer

Blender addon for importing MagicaVoxel (.vox) files.
GNU General Public License v3.0
37 stars 5 forks source link

Fixed CleanUp #3

Closed HexStar27 closed 2 years ago

HexStar27 commented 2 years ago

Hi there, this is my first time doing a pull request, and i don't even know if the creator still visits this repository anyway. The clean up in main is faulty, it tries to remove doubles but it can't since every box is an object and merge by distance doesn't merge vertices from different objects. So i first selected the generated objects and then joined them. This way now it actually merge vertices.

It's a really simple fix but reaaaaally needed.

Maybe i'll try to fix the problem where import just crashes Blender, it looks like it has to do with the size of something... (don't really count on it, i'm new with coding stuff in blender and have 0 idea of how .vox files are formated)

HexStar27 commented 2 years ago

Never mind about the last two lines... for some reason now i can import .vox files that are 256 x 256 x 256 & very caotic.

Notes: During an import of a .vox file of a 256 x 256 x 256 perlin noise, blender allocated +10GB of ram just to stay at 5GB after loading. So now crashing blender with my fix is a little harder (still possible tho).

So problem "solved".